Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Include traceback when logging email PJA exception #18122

Merged
merged 1 commit into from
May 10, 2024
Merged

[24.0] Include traceback when logging email PJA exception #18122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions lib/galaxy/job_execution/actions/post.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,7 @@

from galaxy.model import PostJobActionAssociation
from galaxy.model.base import transaction
from galaxy.util import (
send_mail,
unicodify,
)
from galaxy.util import send_mail
from galaxy.util.custom_logging import get_logger

log = get_logger(__name__)
Expand Down Expand Up @@ -70,8 +67,8 @@ def execute(cls, app, sa_session, action, job, replacement_dict, final_job_state
if link_invocation:
body += f"\n\nWorkflow Invocation Report:\n{link_invocation}"
send_mail(app.config.email_from, to, subject, body, app.config)
except Exception as e:
log.error("EmailAction PJA Failed, exception: %s", unicodify(e))
except Exception:
log.exception("EmailAction PJA Failed")

@classmethod
def get_short_str(cls, pja):
Expand Down
Loading