Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Include traceback when logging email PJA exception #18122

Merged

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented May 10, 2024

The exception that is logged currently is:

EmailAction PJA Failed, exception: 'NoneType' object has no attribute 'name'

The unepxected NoneType is probably job.history, but hard to know.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

The exception that is logged currently is:
```
EmailAction PJA Failed, exception: 'NoneType' object has no attribute 'name'
```
The unepxected NoneType is probably job.history, but hard to know.
@github-actions github-actions bot added this to the 24.1 milestone May 10, 2024
@dannon dannon merged commit 4fd8ad0 into galaxyproject:release_24.0 May 10, 2024
49 of 50 checks passed
@nsoranzo nsoranzo deleted the log_exception_instead_of_error branch May 10, 2024 12:16
@galaxyproject galaxyproject deleted a comment from github-actions bot May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants