Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Decrease log level for not loading IT when ITs are not enabled to warning #17998

Closed
wants to merge 1 commit into from
Closed

[24.0] Decrease log level for not loading IT when ITs are not enabled to warning #17998

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/galaxy/tool_util/toolbox/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -898,6 +898,8 @@ def _load_tool_tag_set(
except OSError as exc:
exc_info = exc.errno != ENOENT
log.error("Error reading tool configuration file from path '%s': %s", path, exc, exc_info=exc_info)
except AssertionError as exc:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe InteractiveTool.__init__() should raise a ServerNotConfiguredForRequest exception instead of using an assert (also the ValueError() there is unnecessary), so we can catch a more specific exception here?

log.warning("Error reading tool configuration file from path '%s': %s", path, exc)
except Exception:
log.exception("Error reading tool from path: %s", path)

Expand Down
Loading