[24.0] Decrease log level for not loading IT when ITs are not enabled to warning #17998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsoranzo
reviewed
Apr 16, 2024
| @@ -898,6 +898,8 @@ def _load_tool_tag_set( | |||
| except OSError as exc: | |||
| exc_info = exc.errno != ENOENT | |||
| log.error("Error reading tool configuration file from path '%s': %s", path, exc, exc_info=exc_info) | |||
| except AssertionError as exc: | |||
There was a problem hiding this comment.
Maybe InteractiveTool.__init__() should raise a ServerNotConfiguredForRequest exception instead of using an assert (also the ValueError() there is unnecessary), so we can catch a more specific exception here?
2 tasks
|
Yeah we should remove them from the tool config. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess this could be debated ? What's your take on this @natefoo ? This is happening on the VGP instance in https://sentry.galaxyproject.org/share/issue/8860299efa3b49a2a620489692db039f/ ... maybe we should instead either enable ITs or remove the tools from the config ?
How to test the changes?
(Select all options that apply)
License