Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Fix workflow run form for workflows with null rename PJA #17929

Merged
merged 1 commit into from
Apr 8, 2024
Merged

[24.0] Fix workflow run form for workflows with null rename PJA #17929

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions lib/galaxy/workflow/modules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2381,13 +2381,14 @@ def __to_pja(self, key, value, step):
action_arguments = None
return PostJobAction(value["action_type"], step, output_name, action_arguments)

def get_informal_replacement_parameters(self, step) -> List[str]:
def get_informal_replacement_parameters(self, step: WorkflowStep) -> List[str]:
"""Return a list of replacement parameters."""
replacement_parameters = set()
for pja in step.post_job_actions:
for argument in pja.action_arguments.values():
for match in re.findall(r"\$\{(.+?)\}", unicodify(argument)):
replacement_parameters.add(match)
if action_arguments := pja.action_arguments:
for argument in action_arguments.values():
for match in re.findall(r"\$\{(.+?)\}", unicodify(argument)):
replacement_parameters.add(match)

return list(replacement_parameters)

Expand Down
Loading