Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Fix workflow run form for workflows with null rename PJA #17929

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Apr 8, 2024

Fixes:

AttributeError: 'NoneType' object has no attribute 'values'
  File "galaxy/web/framework/decorators.py", line 346, in decorator
    rval = func(self, trans, *args, **kwargs)
  File "galaxy/webapps/galaxy/api/workflows.py", line 357, in workflow_dict
    ret_dict = self.workflow_contents_manager.workflow_to_dict(
  File "galaxy/managers/workflows.py", line 907, in workflow_to_dict
    wf_dict = self._workflow_to_dict_run(trans, stored, workflow=workflow, history=history or trans.history)
  File "galaxy/managers/workflows.py", line 1025, in _workflow_to_dict_run
    step_model["replacement_parameters"] = step.module.get_informal_replacement_parameters(step)
  File "galaxy/workflow/modules.py", line 2388, in get_informal_replacement_parameters
    for argument in pja.action_arguments.values():

from https://sentry.galaxyproject.org/share/issue/954ebe7b658f401a8a8e40987d43a91d/

(Please replace this header with a description of your pull request. Please include BOTH what you did and why you made the changes. The "why" may simply be citing a relevant Galaxy issue.)
(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Fixes:
```
AttributeError: 'NoneType' object has no attribute 'values'
  File "galaxy/web/framework/decorators.py", line 346, in decorator
    rval = func(self, trans, *args, **kwargs)
  File "galaxy/webapps/galaxy/api/workflows.py", line 357, in workflow_dict
    ret_dict = self.workflow_contents_manager.workflow_to_dict(
  File "galaxy/managers/workflows.py", line 907, in workflow_to_dict
    wf_dict = self._workflow_to_dict_run(trans, stored, workflow=workflow, history=history or trans.history)
  File "galaxy/managers/workflows.py", line 1025, in _workflow_to_dict_run
    step_model["replacement_parameters"] = step.module.get_informal_replacement_parameters(step)
  File "galaxy/workflow/modules.py", line 2388, in get_informal_replacement_parameters
    for argument in pja.action_arguments.values():
```
from https://sentry.galaxyproject.org/share/issue/954ebe7b658f401a8a8e40987d43a91d/
@github-actions github-actions bot added this to the 24.1 milestone Apr 8, 2024
@mvdbeek mvdbeek changed the title For workflow run form for workflows with null rename PJA [24.0] Fix workflow run form for workflows with null rename PJA Apr 8, 2024
@mvdbeek mvdbeek merged commit c2f45dd into galaxyproject:release_24.0 Apr 8, 2024
50 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants