Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[24.0] Fix step type serialization for StoredWorkflowDetailed models #17716

Merged
merged 3 commits into from
Mar 15, 2024
Merged

[24.0] Fix step type serialization for StoredWorkflowDetailed models #17716

merged 3 commits into from
Mar 15, 2024

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Mar 14, 2024 •
edited by nsoranzo
Loading

Fixes #17713.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek mvdbeek force-pushed the fix_stored_workflow_detailed_models branch from 0fafdfa to 5133abd Compare March 14, 2024 12:42
@jmchilton
Copy link
Member

Thanks for the fix. Test failure looks legit - let me know if you'd like me to take this branch over.

@mvdbeek mvdbeek marked this pull request as ready for review March 14, 2024 16:05
@mvdbeek
Copy link
Member Author

mvdbeek commented Mar 14, 2024

Yep, I suppose we want 27f3480 for API stability if we're already breaking our own tests ...

@mvdbeek mvdbeek force-pushed the fix_stored_workflow_detailed_models branch from d72b543 to 689bb0d Compare March 14, 2024 16:07
@github-actions github-actions bot added this to the 24.1 milestone Mar 14, 2024
@mvdbeek
Copy link
Member Author

mvdbeek commented Mar 14, 2024

The API test error is unrelated now.

@mvdbeek mvdbeek changed the title Fix step type serialization for StoredWorkflowDetailed models [24.0] Fix step type serialization for StoredWorkflowDetailed models Mar 14, 2024
@martenson martenson modified the milestones: 24.1, 24.0 Mar 14, 2024
@mvdbeek mvdbeek merged commit e8f52c3 into galaxyproject:release_24.0 Mar 15, 2024
49 of 53 checks passed
This was referenced Mar 15, 2024
Closed
Merged
@nsoranzo nsoranzo deleted the fix_stored_workflow_detailed_models branch March 18, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martenson martenson martenson approved these changes

Assignees
No one assigned
Labels
area/API area/workflows kind/bug
Projects
None yet
Milestone
24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mvdbeek @jmchilton @martenson @nsoranzo