Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflow response models are not appropriate for data returned #17713

Closed
mvdbeek opened this issue Mar 14, 2024 · 2 comments
Closed

Workflow response models are not appropriate for data returned #17713

mvdbeek opened this issue Mar 14, 2024 · 2 comments
Assignees
@mvdbeek
Labels
area/API area/workflows kind/bug

Comments

@mvdbeek
Copy link
Member

mvdbeek commented Mar 14, 2024

We have different flavors of workflow responses that are all shoved into a single response model, which makes the model less than useful. The model also drops certain fields, like workflow_id for subworkflow steps, which breaks the refactor action on subworkflows.
@mvdbeek
Copy link
Member Author

mvdbeek commented Mar 14, 2024

The step union seems to not use a discriminator field, so everything is serialized as a data input:
Screenshot 2024-03-14 at 12 06 26

@mvdbeek mvdbeek self-assigned this Mar 14, 2024
mvdbeek added a commit to mvdbeek/galaxy that referenced this issue Mar 14, 2024
@mvdbeek
Fix step type serialization for StoredWorkflowDetailed models
0fafdfa 
Fixes galaxyproject#17713.
@mvdbeek mvdbeek mentioned this issue Mar 14, 2024
Merged
4 tasks
mvdbeek added a commit to mvdbeek/galaxy that referenced this issue Mar 14, 2024
@mvdbeek
Fix step type serialization for StoredWorkflowDetailed models
5133abd 
Fixes galaxyproject#17713.
@mvdbeek
Copy link
Member Author

mvdbeek commented Mar 15, 2024

Fixed in #17716

@mvdbeek mvdbeek closed this as completed Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mvdbeek mvdbeek

Labels
area/API area/workflows kind/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mvdbeek