Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity bar preference handling fixes. #17701

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

dannon
Copy link
Member

@dannon dannon commented Mar 13, 2024

xref #17689

With the continuing rollout of the activity bar and the subsequent migration of items exclusively to it (with no other way to access them) we should no longer show the separate preference or feature flag -- it is part of the standard interface.

Would not be surprised if more tests need to be updated, smoke test.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 24.1 milestone Mar 13, 2024
@dannon dannon marked this pull request as draft March 13, 2024 16:15
default and the only option, there is no need for a separate store or
user preference setting -- various items are now accessible *only*
through the activity bar and it is part of the standard interface.
@dannon dannon marked this pull request as ready for review March 13, 2024 16:42
@dannon dannon changed the title Activity bar preference clarifications. Activity bar preference handling fixes. Mar 13, 2024
@guerler guerler added area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes labels Mar 14, 2024
@guerler guerler merged commit 999f3d5 into galaxyproject:dev Mar 14, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants