Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove reference to a non-existent component #17686

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

martenson
Copy link
Member

xref #17634

@ahmedhamidawan does this seem ok?

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@ahmedhamidawan
Copy link
Member

So this removes the upload button from the tool panel, and the upload activity will be the only place for uploads, that's the idea here right?

@dannon
Copy link
Member

dannon commented Mar 13, 2024

@ahmedhamidawan I thought it was already gone from the tool panel in dev?

@ahmedhamidawan
Copy link
Member

ahmedhamidawan commented Mar 13, 2024

@ahmedhamidawan I thought it was already gone from the tool panel in dev?

Something weird happened with a forward-merge somewhere and the import got removed, but i only "removed" it (by adding a v-if=props.workflow for the workflow editor version. Yes it is, I missed that.

@ahmedhamidawan

This comment was marked as resolved.

@dannon
Copy link
Member

dannon commented Mar 13, 2024

@ahmedhamidawan Yes, exactly. That's one of the reasons I had in mind with #17701. I had assumed it was intentional that it was removed, but an oversight that someone might turn the activity bar back off and not be able to upload :)

@martenson
Copy link
Member Author

@ahmedhamidawan it is not just the import, the component does not exist on dev

@ahmedhamidawan
Copy link
Member

ahmedhamidawan commented Mar 13, 2024

@martenson
Yes, I think something happened with a merge and it got removed in dev, but now it seems useful to remove it since the ActivityBar is default
It got removed here: https://github.com/galaxyproject/galaxy/pull/17531/files#diff-c0641cf2ceaef32bb881c757e876af03a693384719c93495a7b6cac42f7edab5

@dannon dannon merged commit 0c588fd into galaxyproject:dev Mar 13, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants