Tool linter: check for leaf nodes with unstripped text content #17656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @davelopez |
I see your point. I cannot remember right now why I added this test. From the #14845 PR description, it sounded like the position (line and character offsets in the text document) of the issues reported by the linter will not match the real document if we have XML comments or additional spaces on it because they get removed by the parser before linting. But it looks like this will not prevent the parser from removing them anyway. |
jmchilton
approved these changes
Mar 11, 2024
bernt-matthias
changed the title
bernt-matthias
force-pushed
the
topic/lint-whitespace-text
branch
from
15d7025 to
02b1b4a
Compare
bernt-matthias
force-pushed
the
topic/lint-whitespace-text
branch
from
02b1b4a to
4603168
Compare
|
This PR was merged without a "kind/" label, please correct. |
jdavcs
changed the title
bernt-matthias
added a commit
to bernt-matthias/galaxy
that referenced
this pull request
May 29, 2024
reverts galaxyproject#17656 we have to many xml nodes where this is allowed (e.g. command) and limiting the linter to a statically defined list of node types seemed difficult to maintain replaced this with a change in the xsd that should lead to the automatic removal of surplus white spaces (leading/trailing are removed, multiple whitespaces are replaced by a single space) for some of the node types that were the original motivation for the linter (if this proves useful this could be used for more node types).
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
another one from the microGalaxy hackaton.
bio.toolsoften contain newlines which are removed by our parser, but it would be better if they would not be there at all (I think).Created problems for instance in the
galaxy_tool_metadata_extractor.Also removes one test (
test_xml_comments_are_ignored) which made no sense (to me).How to test the changes?
(Select all options that apply)
License