Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Remove linter for unstripped text content for tool xml leaves #18252

Merged
merged 1 commit into from
May 31, 2024

Conversation

bernt-matthias
Copy link
Contributor

reverts #17656

we have to many xml nodes where this is allowed (e.g. command) and limiting the linter to a statically defined list of node types seemed difficult to maintain

replaced this with a change in the xsd that should lead to the automatic removal of surplus white spaces (leading/trailing are removed, multiple whitespaces are replaced by a single space) for some of the node types that were the original motivation for the linter (if this proves useful this could be used for more node types).

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

reverts galaxyproject#17656

we have to many xml nodes where this is allowed (e.g. command)
and limiting the linter to a statically defined list of node types
seemed difficult to maintain

replaced this with a change in the xsd that should lead to the
automatic removal of surplus white spaces (leading/trailing are removed,
multiple whitespaces are replaced by a single space) for some of the
node types that were the original motivation for the linter
(if this proves useful this could be used for more node types).
@mvdbeek mvdbeek merged commit fd1cb27 into galaxyproject:release_24.1 May 31, 2024
50 of 51 checks passed
Copy link

This PR was merged without a "kind/" label, please correct.

@bernt-matthias bernt-matthias deleted the revert/17656 branch May 31, 2024 08:34
@jdavcs jdavcs added this to the 24.1 milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants