Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable comments in package dag file #17408

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

jdavcs
Copy link
Member

@jdavcs jdavcs commented Jan 31, 2024

Reasoning:

  • helps with debugging stuff that iterates over packages via this file
  • now we can add any comments to the file explaining its purpose, etc.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek
Copy link
Member

mvdbeek commented Feb 1, 2024

Can you also adjust https://github.com/galaxyproject/galaxy-release-util/blob/main/galaxy_release_util/point_release.py#L119 ?

packages/build_packages.sh Outdated Show resolved Hide resolved
Copy link
Member

@nsoranzo nsoranzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jdavcs
Copy link
Member Author

jdavcs commented Feb 1, 2024

@jdavcs jdavcs merged commit c2c3154 into galaxyproject:dev Feb 1, 2024
48 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants