Skip to content

Commit

Permalink
Merge pull request #17408 from jdavcs/dev_packagebuild_2
Browse files Browse the repository at this point in the history
Enable comments in package dag file
  • Loading branch information
jdavcs authored Feb 1, 2024
2 parents be09082 + 2337c9c commit c2c3154
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 5 deletions.
9 changes: 7 additions & 2 deletions packages/build_packages.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,17 @@ set -ex
# Change to packages directory.
cd "$(dirname "$0")"

# ensure ordered by dependency dag
# Ensure ordered by dependency dag
while read -r package_dir; do
# Ignore empty lines
if [ -z "$package_dir" ]; then
# Skip empty lines
continue
fi
# Ignore lines beginning with `#`
if [[ $package_dir =~ ^#.* ]]; then
continue
fi

printf "\n========= RELEASING PACKAGE %s =========\n\n" "$package_dir"

cd "$package_dir"
Expand Down
12 changes: 9 additions & 3 deletions packages/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -25,19 +25,25 @@ TEST_PYTHON=${TEST_PYTHON:-"python3"}
TEST_ENV_DIR=${TEST_ENV_DIR:-$(mktemp -d -t gxpkgtestenvXXXXXX)}

"$TEST_PYTHON" -m venv "$TEST_ENV_DIR"
# shellcheck disable=SC1091
. "${TEST_ENV_DIR}/bin/activate"
pip install --upgrade pip setuptools wheel
if [ $FOR_PULSAR -eq 0 ]; then
pip install -r../lib/galaxy/dependencies/pinned-typecheck-requirements.txt
fi

# ensure ordered by dependency DAG
# Ensure ordered by dependency DAG
while read -r package_dir || [ -n "$package_dir" ]; do # https://stackoverflow.com/questions/12916352/shell-script-read-missing-last-line
# Ignore empty lines
if [ -z "$package_dir" ]; then
# Skip empty lines
continue
fi
printf "\n========= TESTING PACKAGE ${package_dir} =========\n\n"
# Ignore lines beginning with `#`
if [[ $package_dir =~ ^#.* ]]; then
continue
fi

printf "\n========= TESTING PACKAGE %s =========\n\n" "$package_dir"

cd "$package_dir"

Expand Down

0 comments on commit c2c3154

Please sign in to comment.