-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Multiselect #17331
Custom Multiselect #17331
Conversation
d42b468
to
156762e
Compare
156762e
to
b3db856
Compare
add refocus when closing
adfaa5c
to
099f429
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works well, thanks @ElectronicBlueberry!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it better to move this file to the common components?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently it's quite specific to the tag component, as it only implements the Multiselect features used by the tag component. When this gets used in more places, I'd be happy to move it then.
Supersedes #17269
Replaces the Multiselect used in the tagging component with a custom component.
The custom component renders in a different layer, to prevent z-index layering issues when used inside small components.
It is fully keyboard accessible.
No visual changes.
ping @itisAliRH
How to test the changes?
(Select all options that apply)
License