Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Multiselect #17331

Merged
merged 20 commits into from
Feb 12, 2024
Merged

Conversation

ElectronicBlueberry
Copy link
Member

@ElectronicBlueberry ElectronicBlueberry commented Jan 19, 2024

Supersedes #17269

Replaces the Multiselect used in the tagging component with a custom component.
The custom component renders in a different layer, to prevent z-index layering issues when used inside small components.
It is fully keyboard accessible.

No visual changes.

ping @itisAliRH

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@ElectronicBlueberry ElectronicBlueberry force-pushed the tags-custom-select branch 2 times, most recently from d42b468 to 156762e Compare January 19, 2024 14:23
@ElectronicBlueberry ElectronicBlueberry marked this pull request as ready for review February 6, 2024 13:12
@github-actions github-actions bot added this to the 24.0 milestone Feb 6, 2024
Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well, thanks @ElectronicBlueberry!

@mvdbeek mvdbeek merged commit a3d7b50 into galaxyproject:dev Feb 12, 2024
53 of 54 checks passed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it better to move this file to the common components?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently it's quite specific to the tag component, as it only implements the Multiselect features used by the tag component. When this gets used in more places, I'd be happy to move it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants