Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Multiselect conditionally rendered #17269

Conversation

ElectronicBlueberry
Copy link
Member

Second fix for #17250

Causes the vue multiselect component used inside the stateless tags component to unmount when closed, and uses custom elements to render the closed state instead.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@itisAliRH itisAliRH self-requested a review January 11, 2024 14:46
@ElectronicBlueberry ElectronicBlueberry marked this pull request as ready for review January 18, 2024 11:48
@github-actions github-actions bot added this to the 24.0 milestone Jan 18, 2024
@ElectronicBlueberry ElectronicBlueberry mentioned this pull request Jan 19, 2024
4 tasks
@ElectronicBlueberry
Copy link
Member Author

superseded by #17331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant