Skip to content

Commit

Permalink
Include workflow invocation id in exception logs
Browse files Browse the repository at this point in the history
And downgrade "normal" invocation scheduling errors to info.
  • Loading branch information
mvdbeek committed Jul 24, 2024
1 parent 5c43d00 commit f450cf5
Showing 1 changed file with 9 additions and 2 deletions.
11 changes: 9 additions & 2 deletions lib/galaxy/workflow/run.py
Original file line number Diff line number Diff line change
Expand Up @@ -251,8 +251,15 @@ def invoke(self) -> Dict[int, Any]:
step_delayed = delayed_steps = True
self.progress.mark_step_outputs_delayed(step, why=de.why)
except Exception as e:
log.exception(
"Failed to schedule %s, problem occurred on %s.",
log_function = log.exception
if isinstance(e, modules.FailWorkflowEvaluation) and e.why.reason not in (
"unexpected_failure",
"expression_evaluation_failed",
):
log_function = log.info
log_function(
"Failed to schedule %s for %s, problem occurred on %s.",
self.workflow_invocation.log_str(),
self.workflow_invocation.workflow.log_str(),
step.log_str(),
)
Expand Down

0 comments on commit f450cf5

Please sign in to comment.