Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Main and Pr build workflows #160

Closed
wants to merge 11 commits into from
Closed

Added Main and Pr build workflows #160

wants to merge 11 commits into from

Conversation

jaydee029
Copy link

@galasa-team
Copy link

Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building'

Copy link
Contributor

@jadecarino jadecarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to be made for this one please - also it seems you're missing a docker build step of the simplatform jar image in the PR build, if you could add that that would be great, thanks.

.github/workflows/pr-build.yaml Outdated Show resolved Hide resolved
.github/workflows/pr-build.yaml Outdated Show resolved Hide resolved
.github/workflows/pr-build.yaml Outdated Show resolved Hide resolved
dockerfiles/dockerfile.simplatform Outdated Show resolved Hide resolved
.github/workflows/build.yaml Outdated Show resolved Hide resolved
.github/workflows/build.yaml Outdated Show resolved Hide resolved
.github/workflows/build.yaml Outdated Show resolved Hide resolved
.github/workflows/build.yaml Outdated Show resolved Hide resolved
.github/workflows/build.yaml Outdated Show resolved Hide resolved
.github/workflows/build.yaml Outdated Show resolved Hide resolved
jaydee029 and others added 2 commits August 12, 2024 23:37
@galasa-team
Copy link

Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building'

@jaydee029
Copy link
Author

Changes to be made for this one please - also it seems you're missing a docker build step of the simplatform jar image in the PR build, if you could add that that would be great, thanks.

Didn't realize i missed it, fixed it now.

Copy link
Contributor

@jadecarino jadecarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - I'll merge on your behalf when the Galasa 0.36.0 release is done

Copy link
Contributor

@jadecarino jadecarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for building

@galasa-team
Copy link

Build successful

Copy link
Contributor

@jadecarino jadecarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed an error when I ran the workflow - please can you make these two updates?

.github/workflows/build.yaml Outdated Show resolved Hide resolved
.github/workflows/pr-build.yaml Outdated Show resolved Hide resolved
@galasa-team
Copy link

Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building'

Copy link
Contributor

@jadecarino jadecarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for building

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-simplatform-pr-160-sj89d for details. If you are unable to do so, please contact a member of the Galasa team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants