Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build 'simplatform' with GH Actions #1943

Closed
8 tasks done
Tracked by #1845
jadecarino opened this issue Jul 30, 2024 · 3 comments
Closed
8 tasks done
Tracked by #1845

Build 'simplatform' with GH Actions #1943

jadecarino opened this issue Jul 30, 2024 · 3 comments
Assignees

Comments

@jadecarino
Copy link

jadecarino commented Jul 30, 2024

Story

As a contributor to the galasa open source project, I want builds to be in the open, and use github actions, so that I can see build logs, see built artifacts, benefit from integration with github actions, and all without using any resources within the secretive IBM firewall.

Background

There are many benefits of moving our infrastructure to use github actions.

  • Builds will be immediately kicked off, no 2-minute delay for them to start.
  • build logs are available for ages
  • built artifacts can be made available within the build results

Objectives:

For reference, look at the existing Tekton pipelines for simplatform and the associated Tasks that it utilises, but remove/adapt Tasks as appropriate for GitHub actions.

Tasks

  • Use GitHub actions to build the 'simplatform' repository for Pull Requests and merges to Main
  • Build the simplatform application code with Maven (task maven-build-simplatform-application)
  • Build the simbank tests with Maven (task maven-build-simbank-tests)
  • Build the simplatform maven repo Docker image (task docker-build-simplatform-repo)
  • Build the simplatform jar Docker image (task docker-build-simplatform-jar)
  • For PR builds do not publish the images
  • For Main builds publish the images to GHCR
  • For Main builds recycle the ArgoCD app
@jadecarino jadecarino converted this from a draft issue Jul 30, 2024
@jadecarino jadecarino added the OMP Summer Mentorship These stories are set aside for the mentee to complete as part of the OMP Summer Mentorship label Jul 30, 2024
@jadecarino jadecarino moved this from 4 Release backlog to 📋 5 Backlog in galasa-dev team Jul 30, 2024
@jadecarino jadecarino changed the title Build Simplatform with GH Actions Build 'simplatform' with GH Actions Jul 30, 2024
@jadecarino
Copy link
Author

Waiting for 0.36.0 release to merge in PR: galasa-dev/simplatform#160

@jadecarino
Copy link
Author

Not closed this off yet as the builds (both GH and Tekton) are failing for Simplatform which I'll investigate tomorrow.

@jadecarino jadecarino removed the OMP Summer Mentorship These stories are set aside for the mentee to complete as part of the OMP Summer Mentorship label Aug 30, 2024
@jadecarino jadecarino self-assigned this Aug 30, 2024
@jadecarino
Copy link
Author

The Simplatform Tekton and GH builds are failing since upgrading the builds to use Java 17, but without upgrading the Maven versions to 3.9.+. The Tekton build uses Maven 3.8.7 and the GH build uses 3.8.8. Tekton can be updated, but I've been searching but cannot find a way to set the Maven version you want in a GH Actions build. Since it's using less than Maven 3.9, it's using the maven-war-plugin at 2.2, which is incompatible with Java 17.

To get the GH build working, I'll have to update the galasa-simplatform-application pom.xml to state which maven-war-plugin to use as 3.3.2. I'll then also need to update the galasa-simplatform-application version to 0.37.0 (currently 0.24.0) as there's just a change to the pom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant