Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

massive amounts of duplicates shown by formatter due to labels being duplicated #310

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

techcobweb
Copy link
Contributor

@techcobweb techcobweb commented Dec 2, 2024

Signed-off-by: Mike Cobbett [email protected]

Why ?

galasa-dev/projectmanagement#2049

The actual problem: The formatter thought '' (blank) was a custom label for the results.
If there were 30 tests with a '' result label, those 30 tests were shown 30 times.

Unit test added to verify that custom labels only get returned once.

Seems to work much better now.

@techcobweb
Copy link
Contributor Author

As I had to add the log statements to debug the issue, leaving them there so that any similar issues are easier to debug. And I can't see the log ever being collected for the runs get unless there is a problem anyway.

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-310-ph6vr for details. If you are unable to do so, please contact a member of the Galasa team.

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-310-ls5vx for details. If you are unable to do so, please contact a member of the Galasa team.

@galasa-team
Copy link

Build successful

…n a normal test submit flow

Signed-off-by: Mike Cobbett <[email protected]>
@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-310-hvrht for details. If you are unable to do so, please contact a member of the Galasa team.

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-310-trbc8 for details. If you are unable to do so, please contact a member of the Galasa team.

@galasa-team
Copy link

Build successful

@techcobweb techcobweb merged commit 928090f into main Dec 2, 2024
6 checks passed
@techcobweb techcobweb deleted the mcobbett-remove-duplicate-results-formatted branch December 2, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants