Galasa is duplicating run info returned to "galasactl runs get"

[Tom-Slattery]

Describe the bug

Galasactl runs get returns many more runs for test runs that failed due to resource limitations and were requeued by the Galasa Ecosystem. Identified this bug with @eamansour and found that it also applied to the Galasa team's ecosystem.

There also seems to be no indication that a test that has run into a resource limitation error has been requeued, as far as the Galasa RAS is concerned the test is still running. This results in the test being returned by Galasactl runs get with the --active flag when the test has actually long since terminated.

Steps to reproduce

1. Create a Galasa test class that uses a resource that is limited
2. Make the test fail due to ResourceLimitation and let it be requeued to run by the Galasa ecosystem a few times
3. Allow the test to run
4. Use Galasactl runs get to get list of runs from the last few days
5. You should see that there are many more runs than there should be for the test that was requeued. There will be many more runs returned to Galasactl runs get than there are entries for couchdb.

Expected behavior

Runs get should return correct number of tests, ideally returning only actively running tests with --active flag

[eamansour]

Looks like the duplication of results is a client-side defect in galasactl - added a bit more logging locally and ran galasactl runs get --age 1w, and the results received from the API server were far fewer than the results printed out in the final summary view.

In this example, the API server returned 751 runs:

2024/11/11 18:38:52 Requesting page '1' 
2024/11/11 18:38:53 Received 100 results for page 1 - Number of results: 100
2024/11/11 18:38:53 Requesting page '2' 
2024/11/11 18:38:53 Received 100 results for page 2 - Number of results: 200
2024/11/11 18:38:53 Requesting page '3' 
2024/11/11 18:38:53 Received 100 results for page 3 - Number of results: 300
2024/11/11 18:38:53 Requesting page '4' 
2024/11/11 18:38:53 Received 100 results for page 4 - Number of results: 400
2024/11/11 18:38:53 Requesting page '5' 
2024/11/11 18:38:53 Received 100 results for page 5 - Number of results: 500
2024/11/11 18:38:53 Requesting page '6' 
2024/11/11 18:38:53 Received 100 results for page 6 - Number of results: 600
2024/11/11 18:38:53 Requesting page '7' 
2024/11/11 18:38:54 Received 100 results for page 7 - Number of results: 700
2024/11/11 18:38:54 Requesting page '8' 
2024/11/11 18:38:54 Received 51 results for page 8 - Number of results: 751
2024/11/11 18:38:54 Expected total: 751

But the final summary view showed a total of 1563 runs:

Total:1563 Passed:109 Failed:13 EnvFail:600 Active:841

[techcobweb]

This is a client-side issue in the reporting of the tests in the formatting.

[techcobweb]

Fix is here: galasa-dev/cli#310

[techcobweb]

delivered