Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update section.go #3

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Update section.go #3

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1becbf5
Update section.go
enricovittorini Aug 14, 2023
f55dd38
Update section.go
enricovittorini Aug 14, 2023
3b7403d
fix misisng if
enricovittorini Aug 14, 2023
29059ad
debugging
enricovittorini Aug 14, 2023
79173c5
fix
enricovittorini Aug 14, 2023
484c1ac
fix
enricovittorini Aug 14, 2023
285e664
clean comment
enricovittorini Aug 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions section.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ func (infosec *InfoSection) Decode(bd *bitDecoder) bool {
}
infosec.SectionSyntaxIndicator = bd.asFlag()
infosec.Private = bd.asFlag()
if infosec.Private {
return false
}
Copy link
Owner

@futzu futzu Aug 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct, as far as the specification goes, but this gets us nothing, I've never seen this value used, and that's why Intentionally don't check it.

infosec.Reserved = bd.asHex(2)
infosec.SectionLength = bd.uInt16(12)
infosec.ProtocolVersion = bd.uInt8(8)
Expand Down