Update section.go #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a check for false on private indicator: private_indicator – This is a 1-bit flag that shall be set to 0.
added a check on protocol version protocol_version: @ present, this attribute shall be set to 0.
futzu
reviewed
Aug 15, 2023
futzu
reviewed
Aug 15, 2023
There was a problem hiding this comment.
futzu/threefive#88 is an example of what I'm talking about with people using custom identifiers.
| @@ -27,6 +27,9 @@ func (infosec *InfoSection) Decode(bd *bitDecoder) bool { | |||
| } | |||
| infosec.SectionSyntaxIndicator = bd.asFlag() | |||
| infosec.Private = bd.asFlag() | |||
| if infosec.Private { | |||
| return false | |||
| } | |||
There was a problem hiding this comment.
You are correct, as far as the specification goes, but this gets us nothing, I've never seen this value used, and that's why Intentionally don't check it.
futzu
reviewed
Aug 15, 2023
futzu
reviewed
Aug 15, 2023
|
helloooooo |
|
Agree let's do it as warning |
|
Are you going to give me an update with the warnings? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check for false on private indicator:
private_indicator – This is a 1-bit flag that shall be set to 0.