-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Spacing, Divider 컴포넌트 추가 #171
Open
xodms0309
wants to merge
4
commits into
feat/v2
Choose a base branch
from
feat/issue-72
base: feat/v2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
import type { Meta, StoryObj } from '@storybook/react'; | ||
|
||
import Divider from './Divider'; | ||
|
||
const meta: Meta<typeof Divider> = { | ||
title: 'common/Divider', | ||
component: Divider, | ||
}; | ||
|
||
export default meta; | ||
type Story = StoryObj<typeof meta>; | ||
|
||
export const Default: Story = { | ||
args: { | ||
variant: 'default', | ||
}, | ||
}; | ||
|
||
export const Light: Story = { | ||
args: { | ||
variant: 'light', | ||
}, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
import cx from 'classnames'; | ||
import type { ComponentPropsWithoutRef } from 'react'; | ||
|
||
import { divider, dividerHeight, dividerWidth } from './divider.css'; | ||
|
||
import { assignInlineVars } from '@vanilla-extract/dynamic'; | ||
|
||
export interface DividerProps extends ComponentPropsWithoutRef<'hr'> { | ||
variant?: 'default' | 'light' | 'navigation'; | ||
width?: string; | ||
height?: string; | ||
} | ||
|
||
const Divider = ({ variant = 'default', width = '100%', height = '1px', ...props }: DividerProps) => { | ||
return ( | ||
<hr | ||
aria-hidden | ||
className={cx(divider({ variant }))} | ||
style={assignInlineVars({ | ||
[dividerWidth]: width ?? '100%', | ||
[dividerHeight]: height ?? '1px', | ||
})} | ||
{...props} | ||
/> | ||
); | ||
}; | ||
|
||
export default Divider; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
import { vars } from '@/styles/theme.css'; | ||
import { createVar, style } from '@vanilla-extract/css'; | ||
import { recipe } from '@vanilla-extract/recipes'; | ||
|
||
export const dividerWidth = createVar(); | ||
export const dividerHeight = createVar(); | ||
|
||
export const dividerBase = style({ | ||
width: dividerWidth, | ||
height: dividerHeight, | ||
border: 0, | ||
}); | ||
|
||
export const divider = recipe({ | ||
base: dividerBase, | ||
variants: { | ||
variant: { | ||
default: { backgroundColor: vars.colors.border.default }, | ||
light: { backgroundColor: vars.colors.border.light }, | ||
navigation: { backgroundColor: vars.colors.border.navigation }, | ||
}, | ||
}, | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,81 @@ | ||
import type { Meta, StoryObj } from '@storybook/react'; | ||
import type { PropsWithChildren } from 'react'; | ||
|
||
import Spacing from './Spacing'; | ||
|
||
import { vars } from '@/styles/theme.css'; | ||
|
||
const meta: Meta<typeof Spacing> = { | ||
title: 'common/Spacing', | ||
component: Spacing, | ||
}; | ||
|
||
export default meta; | ||
type Story = StoryObj<typeof Spacing>; | ||
|
||
const Container = ({ children, vertical }: PropsWithChildren<{ vertical?: boolean }>) => { | ||
return ( | ||
<div | ||
style={{ | ||
display: 'flex', | ||
flexDirection: `${vertical ? 'column' : 'row'}`, | ||
}} | ||
> | ||
{children} | ||
</div> | ||
); | ||
}; | ||
|
||
const Box = () => { | ||
return ( | ||
<div | ||
style={{ | ||
width: '100px', | ||
height: '50px', | ||
backgroundColor: `${vars.colors.primary}`, | ||
}} | ||
/> | ||
); | ||
}; | ||
|
||
export const Default: Story = { | ||
render: ({ direction = 'vertical', size }) => ( | ||
<Container vertical={direction === 'vertical'}> | ||
<Box /> | ||
<Spacing direction={direction} size={size} /> | ||
<Box /> | ||
<Spacing direction={direction} size={size} /> | ||
<Box /> | ||
<Spacing direction={direction} size={size} /> | ||
<Box /> | ||
</Container> | ||
), | ||
}; | ||
|
||
export const Vertical: Story = { | ||
render: ({ size }) => ( | ||
<Container vertical> | ||
<Box /> | ||
<Spacing direction="vertical" size={size} /> | ||
<Box /> | ||
<Spacing direction="vertical" size={size} /> | ||
<Box /> | ||
<Spacing direction="vertical" size={size} /> | ||
<Box /> | ||
</Container> | ||
), | ||
}; | ||
|
||
export const Horizontal: Story = { | ||
render: ({ size }) => ( | ||
<Container> | ||
<Box /> | ||
<Spacing direction="horizontal" size={size} /> | ||
<Box /> | ||
<Spacing direction="horizontal" size={size} /> | ||
<Box /> | ||
<Spacing direction="horizontal" size={size} /> | ||
<Box /> | ||
</Container> | ||
), | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
import type { ComponentPropsWithoutRef } from 'react'; | ||
|
||
import { spacing, spacingSize } from './spacing.css'; | ||
|
||
import { assignInlineVars } from '@vanilla-extract/dynamic'; | ||
|
||
type SpacingDirections = 'vertical' | 'horizontal'; | ||
|
||
export interface SpacingProps extends ComponentPropsWithoutRef<'div'> { | ||
direction?: SpacingDirections; | ||
size: number; | ||
} | ||
|
||
const Spacing = ({ direction = 'vertical', size, ...props }: SpacingProps) => { | ||
return ( | ||
<div | ||
aria-hidden="true" | ||
className={direction === 'vertical' ? spacing['vertical'] : spacing['horizontal']} | ||
style={assignInlineVars({ | ||
[spacingSize]: `${size}px`, | ||
})} | ||
{...props} | ||
/> | ||
); | ||
}; | ||
|
||
export default Spacing; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
import { createVar, styleVariants } from '@vanilla-extract/css'; | ||
|
||
export const spacingSize = createVar(); | ||
|
||
export const spacing = styleVariants({ | ||
vertical: [{ height: spacingSize }], | ||
horizontal: [{ width: spacingSize }], | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
궁금한게 Divider variant의 기본값이 default던데 따로 명시해야 하는건가용?!?!