Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Spacing, Divider 컴포넌트 추가 #171

Open
wants to merge 4 commits into
base: feat/v2
Choose a base branch
from

Conversation

xodms0309
Copy link
Member

Issue

✨ 구현한 기능

  • Divider와 Spacing 컴포넌트를 추가하고 교체했습니다

📢 논의하고 싶은 내용

  • x

🎸 기타

  • x

⏰ 일정

  • 추정 시간 :
  • 걸린 시간 : 1시간 레전드 노가다

@xodms0309 xodms0309 self-assigned this Jul 28, 2024
Copy link

🔗 배포된 storybook 주소: https://65f015a4aed45406385006ee-vszkjkflol.chromatic.com/

Copy link
Contributor

@hae-on hae-on left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

컴포넌트 교체까지 다 해놓다니 짱 👍👍👍

<div style={{ height: '20px' }} />
<hr style={{ border: '0.5px solid #e6e6e6' }} />
<Spacing size={20} />
<Divider variant="default" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

궁금한게 Divider variant의 기본값이 default던데 따로 명시해야 하는건가용?!?!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Divider, Spacing 컴포넌트 추가
2 participants