Don't reuse the "ssh" group for our own access control #7317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Still work in progress, I need to actually test the upgrade path) |
legoktm
force-pushed
the
stg-ssh-migration
branch
2 times, most recently
from
71daebe
to
e9fa7b7
Compare
legoktm
force-pushed
the
stg-ssh-migration
branch
2 times, most recently
from
3af5a1f
to
23d9aca
Compare
|
OK, I've finished testing this and it (now) works, I learned that |
legoktm
force-pushed
the
stg-ssh-migration
branch
2 times, most recently
from
abe18eb
to
6cba1b5
Compare
The "ssh" group was supposed to be an internal group that was used by openssh itself for privilege separation. It's since been renamed to "_ssh"[1] to clarify that it's internal-only and flagged that we shouldn't be using it either. Instead, create a new "sdssh" group, add our users to it, and use it in the sshd_config. For upgrades, we migrate users to the new group and then update sshd_config and iptables rules. [1] https://salsa.debian.org/ssh-team/openssh/-/blob/eac38305fc5d8eb8301a106294cf6c79447bdeb3/debian/openssh-client.postinst Fixes #7316.
legoktm
force-pushed
the
stg-ssh-migration
branch
from
6cba1b5
to
be5ba46
Compare
zenmonkeykstop
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
The "ssh" group was supposed to be an internal group that was used by openssh itself for privilege separation. It's since been renamed to "_ssh"[1] to clarify that it's internal-only and flagged that we shouldn't be using it either.
Instead, create a new "sdssh" group, add our users to it, and use it in the sshd_config.
For upgrades, we migrate users to the new group and then update sshd_config and iptables rules.
[1] https://salsa.debian.org/ssh-team/openssh/-/blob/eac38305fc5d8eb8301a106294cf6c79447bdeb3/debian/openssh-client.postinst
Fixes #7316.
Testing
How should the reviewer test this PR?
id sdadminincludes "sdssh" and not plain "ssh"Deployment
Any special considerations for deployment? Both new installs and upgrades are considered
Checklist