Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mako 1.2.2 wheel #386

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Add mako 1.2.2 wheel #386

merged 1 commit into from
Oct 5, 2022

Conversation

gonzalo-bulnes
Copy link
Contributor

@gonzalo-bulnes gonzalo-bulnes commented Oct 5, 2022

Description

Adds mako 1.2.2 for use in the SecureDrop Client.
The diff erview was performed by @zenmonkeykstop: https://github.com/freedomofpress/securedrop-debian-packaging/wiki/mako-1.0.7-to-1.2.2

Unblocks freedomofpress/securedrop-client#1573

Test plan

  • Automated tests (Circle CI):
    • All Bullseye jobs are passing
    • Bookworm failures are not ignored:
      • This PR does not introduce any new Bookworm failures
      • An issue is open for all new Bookworm failures
  • Security:
    • A diff review was performed for all build dependencies

@gonzalo-bulnes
Copy link
Contributor Author

gonzalo-bulnes commented Oct 5, 2022

Note: the pull request template did not kick-in, I had to copy it by hand and I don't see what's wrong. The path to the templates seems all right, and so do the metadata headers. 🤔

Edit: I opened #387 to track this.

Copy link
Member

@legoktm legoktm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All checks out. I also built the wheel locally and got the exact same checksum as committed here (yay for reproducibility!)

@legoktm legoktm merged commit f6225f6 into main Oct 5, 2022
@legoktm legoktm deleted the add-wheels-mako-1.2.2 branch October 5, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants