Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade mako==1.2.2 #1574

Merged
merged 2 commits into from
Oct 6, 2022
Merged

Upgrade mako==1.2.2 #1574

merged 2 commits into from
Oct 6, 2022

Conversation

gonzalo-bulnes
Copy link
Contributor

@gonzalo-bulnes gonzalo-bulnes commented Oct 4, 2022

Description

From GitHub's Dependabot alerts:

Sqlalchemy mako before 1.2.2 is vulnerable to Regular expression
Denial of Service when using the Lexer class to parse.
This also affects babelplugin and linguaplugin.

The wheel was added in: freedomofpress/securedrop-builder#386

Fixes #1566
Unblocks #1571
Unblocks #1573

Test Plan

  • Confirm that CI is passing for Bullseye 🍏
  • Confirm that mako==1.2.2 is being installed

From GitHub Dependabot alert:

  Sqlalchemy mako before 1.2.2 is vulnerable to Regular expression
  Denial of Service when using the Lexer class to parse.
  This also affects babelplugin and linguaplugin.
@gonzalo-bulnes gonzalo-bulnes requested a review from a team as a code owner October 4, 2022 23:49
@gonzalo-bulnes gonzalo-bulnes added the 🔥 Blocker This PR is somewhat urgent. label Oct 4, 2022
@gonzalo-bulnes gonzalo-bulnes mentioned this pull request Oct 5, 2022
3 tasks
@gonzalo-bulnes
Copy link
Contributor Author

The CI pipeline should be triggered again once freedomofpress/securedrop-builder#386 is merged. The Bullseye pipeline jobs will be passing 🍏

@gonzalo-bulnes gonzalo-bulnes requested review from legoktm, eaon and a user October 5, 2022 23:56
@gonzalo-bulnes
Copy link
Contributor Author

This is ready for review now 🙂 - the redness of the build is due to Bookworm jobs that are not part of the test plan. 🍎 🍏

@legoktm legoktm merged commit c652d35 into main Oct 6, 2022
@legoktm legoktm deleted the upgrade-mako branch October 6, 2022 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥 Blocker This PR is somewhat urgent.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade mako==1.2.2
2 participants