Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add babeliser #146

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add babeliser #146

wants to merge 2 commits into from

Conversation

ShaunSHamilton
Copy link
Member

I have lost count what attempt number this is at getting this going.

Copy link

socket-security bot commented Feb 14, 2024

@ShaunSHamilton ShaunSHamilton marked this pull request as ready for review February 15, 2024 12:30
@ShaunSHamilton ShaunSHamilton requested a review from a team as a code owner February 15, 2024 12:30
@ojeytonwilliams ojeytonwilliams self-assigned this Feb 15, 2024
@ojeytonwilliams
Copy link
Contributor

@ShaunSHamilton any idea why, when the PR adds dependencies, the package-lock shrank a huge amount? I don't know why that would happen.

@ShaunSHamilton
Copy link
Member Author

@ojeytonwilliams My two best guesses:

  1. At some point, the package-lock went out of sync with our actual packages 🤷‍♂️
  2. Including all the babel stuff removes all transitive dependencies

@ojeytonwilliams
Copy link
Contributor

@ojeytonwilliams My two best guesses:

  1. At some point, the package-lock went out of sync with our actual packages 🤷‍♂️
  2. Including all the babel stuff removes all transitive dependencies

Weird. Thanks, I'll have a look at the whole thing soon.

@ojeytonwilliams
Copy link
Contributor

soon.

Turns out it's just package-lock version 3 vs 2, so there's nothing to fix. I'll bump the minimum npm version separately.

@ojeytonwilliams
Copy link
Contributor

Hey, @ShaunSHamilton, I don't 100% understand the failure, but it may be surfacing a bug in strip-comments. I'll see if I can verify and/or fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants