Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: basic js ast explorer #155

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ShaunSHamilton
Copy link
Member

This is a more basic AST explorer than Babeliser. I am still not 100% about the API, but have already started adding/using it in:
https://github.com/freeCodeCamp/back-end-development-and-apis/blob/64f5270dab04eb80026aed10f91dfdfda4dfda3d/curriculum/locales/english/learn-npm-by-building-an-npm-module.md?plain=1#L1298-L1317

@ShaunSHamilton ShaunSHamilton requested a review from a team as a code owner February 24, 2024 23:52
@ojeytonwilliams
Copy link
Contributor

If we have this, do we need #146?

@ShaunSHamilton
Copy link
Member Author

If we have this, do we need #146?

Yes, because that is a much more customizable API. This is just for the "majority" cases.

Also, we use Babeliser elsewhere already, and I cannot see us re-writing the tests to use Tower, once it is more fledged.

@ojeytonwilliams
Copy link
Contributor

Sure. I wasn't suggesting that Babelizer needs be retired, just checking if we need in it in the helpers.

@ShaunSHamilton
Copy link
Member Author

@ojeytonwilliams That is definitely up for discussion. So, let us put it like this:
This PR should be prioritised over the Babeliser one.

@a2937
Copy link
Member

a2937 commented Apr 26, 2024

This looks lovely and I'd like to try it out sometime in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants