refactor: validate attendance in payroll #705
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Incorrect message for completely marked attendance Ref Issue
Before:
"Attendance records not found" is a misleading message here. It actually means attendance is already marked and the list is empty.
After:
2. Employees having 0 attendance records in the month are not flagged at all
Before:
Here, all the employees have unmarked attendance but only 2 are shown (they have some records, others have 0). So they get left out in an inner join query
After:
Fetching employee attendance via left join to include employees with 0 records too. All flagged:
3. Employees having relieving date in mid-month are also flagged in spite of complete attendance
Before:
Rucha Mahabal is flagged as unmarked attendance. Relieving date (18th July). All attendance records have been marked till the 18th.
After:
Not flagged:
4. Poor view enhanced
After:
Others: