refactor: validate attendance in payroll #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- decoupled functions, better naming, remove unnecessary code - missing attendance query not fetching employees with no attendance records - relieving date not considered while fetching unmarked attendance
ruchamahabal
force-pushed
the
refactor-validate-attendance-v14
branch
from
8e0dbaf
to
df1326a
Compare
ruchamahabal
force-pushed
the
refactor-validate-attendance-v14
branch
from
df1326a
to
4c50864
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## version-14-hotfix #723 +/- ##
=====================================================
+ Coverage 73.09% 73.42% +0.32%
=====================================================
Files 192 192
Lines 9924 9933 +9
=====================================================
+ Hits 7254 7293 +39
+ Misses 2670 2640 -30
|
ruchamahabal
commented
Jul 22, 2023
ruchamahabal
commented
Jul 22, 2023
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
🎉 This PR is included in version 14.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #705