-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure prettier pre-commit hook and reformat existing files #97
Conversation
Codecov Report
@@ Coverage Diff @@
## main #97 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 1 1
Lines 5 5
=====================================
Misses 5 5 |
Thanks for the contribution @kenibrewer, it looks promising! If it's okay with you, I'll review this one after we have finalized the PR regarding devcontainers to reduce the diff a bit. I just placed one more comment on that PR, I think we can merge after we have handled that! |
51f48b0
to
dd1b52e
Compare
@fpgmaas This is now ready for review. Two of the checks failed, but they succeeded when I triggered them again by creating a pull request against my fork. I think the issue is probably something due to cache not being invalidated when I force-pushed a rebase to my branch. |
@fpgmaas When do you think you'll have a chance to review this PR? I've got some docs changes/improvements I'd like to submit, but the diffs would be pretty complicated if I tried to submit them without this one merged into main. |
Hi @kenibrewer, sorry for my relatively slow response! Pull request looks good to me. Am I correct in understanding that the issue. outlined here should not be a problem since we only format indentations and line lengths, and thus there are no issues that can pop-up in our current Jinja templates once they are parsed? |
@fpgmaas Correct. Prettier is similar to black and it only formats code in ways that doesn't change the functionality. Beyond that, the prettier pre-commit hook for |
PR Checklist
docs
is updatedDescription of changes
This PR is intended to be merged after #95 . It addresses #96.
It includes the following changes: