-
Notifications
You must be signed in to change notification settings - Fork 62
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Added prettier pre-commit hook and formatted files (#97)
- Loading branch information
1 parent
9c49026
commit 41d853b
Showing
27 changed files
with
348 additions
and
349 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,32 +1,28 @@ | ||
// For format details, see https://aka.ms/devcontainer.json. For config options, see the | ||
// README at: https://github.com/devcontainers/templates/tree/main/src/python | ||
{ | ||
"name": "Cookiecutter Poetry", | ||
// Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile | ||
"image": "mcr.microsoft.com/devcontainers/python:1-3.11-bullseye", | ||
"features": { | ||
"ghcr.io/devcontainers-contrib/features/cookiecutter:2": {}, | ||
"ghcr.io/devcontainers-contrib/features/poetry:2": {} | ||
}, | ||
"name": "Cookiecutter Poetry", | ||
// Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile | ||
"image": "mcr.microsoft.com/devcontainers/python:1-3.11-bullseye", | ||
"features": { | ||
"ghcr.io/devcontainers-contrib/features/cookiecutter:2": {}, | ||
"ghcr.io/devcontainers-contrib/features/poetry:2": {} | ||
}, | ||
|
||
// Use 'postCreateCommand' to run commands after the container is created. | ||
"postCreateCommand": "./.devcontainer/postCreateCommand.sh", | ||
// Use 'postCreateCommand' to run commands after the container is created. | ||
"postCreateCommand": "./.devcontainer/postCreateCommand.sh", | ||
|
||
// Configure tool-specific properties. | ||
"customizations": { | ||
"vscode": { | ||
"extensions": [ | ||
"ms-python.python" | ||
], | ||
"settings": { | ||
"python.testing.pytestArgs": [ | ||
"tests" | ||
], | ||
"python.testing.unittestEnabled": false, | ||
"python.testing.pytestEnabled": true, | ||
"python.defaultInterpreterPath": "/workspaces/cookiecutter-poetry/.venv/bin/python", | ||
"python.testing.pytestPath": "/workspaces/cookiecutter-poetry/.venv/bin/pytest" | ||
} | ||
} | ||
} | ||
// Configure tool-specific properties. | ||
"customizations": { | ||
"vscode": { | ||
"extensions": ["ms-python.python", "editorconfig.editorconfig"], | ||
"settings": { | ||
"python.testing.pytestArgs": ["tests"], | ||
"python.testing.unittestEnabled": false, | ||
"python.testing.pytestEnabled": true, | ||
"python.defaultInterpreterPath": "/workspaces/cookiecutter-poetry/.venv/bin/python", | ||
"python.testing.pytestPath": "/workspaces/cookiecutter-poetry/.venv/bin/pytest" | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
[*] | ||
max_line_length = 120 | ||
|
||
[*.json] | ||
indent_style = space | ||
indent_size = 4 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
# Contributing | ||
|
||
Contributions are welcome, and they are greatly appreciated! Every | ||
little bit helps, and credit will always be given. | ||
Contributions are welcome, and they are greatly appreciated! | ||
Every little bit helps, and credit will always be given. | ||
|
||
You can contribute in many ways: | ||
|
||
|
@@ -13,128 +13,114 @@ Report bugs at <https://github.com/fpgmaas/cookiecutter-poetry/issues | |
|
||
If you are reporting a bug, please include: | ||
|
||
- Your operating system name and version. | ||
- Any details about your local setup that might be helpful in | ||
troubleshooting. | ||
- Detailed steps to reproduce the bug. | ||
- Your operating system name and version. | ||
- Any details about your local setup that might be helpful in troubleshooting. | ||
- Detailed steps to reproduce the bug. | ||
|
||
## Fix Bugs | ||
|
||
Look through the GitHub issues for bugs. Anything tagged with "bug" | ||
and "help wanted" is open to whoever wants to implement a fix for it. | ||
Look through the GitHub issues for bugs. | ||
Anything tagged with "bug" and "help wanted" is open to whoever wants to implement a fix for it. | ||
|
||
## Implement Features | ||
|
||
Look through the GitHub issues for features. Anything tagged with | ||
"enhancement" and "help wanted" is open to whoever wants to | ||
implement it. | ||
Look through the GitHub issues for features. | ||
Anything tagged with "enhancement" and "help wanted" is open to whoever wants to implement it. | ||
|
||
## Write Documentation | ||
|
||
Cookiecutter PyPackage could always use more documentation, whether as | ||
part of the official docs, in docstrings, or even on the web in blog | ||
posts, articles, and such. | ||
Cookiecutter PyPackage could always use more documentation, whether as part of the official docs, in docstrings, or even on the web in blog posts, articles, and such. | ||
|
||
## Submit Feedback | ||
|
||
The best way to send feedback is to file an issue at | ||
<https://github.com/fpgmaas/cookiecutter-poetry/issues. | ||
The best way to send feedback is to file an issue at <https://github.com/fpgmaas/cookiecutter-poetry/issues. | ||
|
||
If you are proposing a new feature: | ||
|
||
- Explain in detail how it would work. | ||
- Keep the scope as narrow as possible, to make it easier to | ||
implement. | ||
- Remember that this is a volunteer-driven project, and that | ||
contributions are welcome :) | ||
- Explain in detail how it would work. | ||
- Keep the scope as narrow as possible, to make it easier to implement. | ||
- Remember that this is a volunteer-driven project, and that contributions are welcome :) | ||
|
||
# Get Started! | ||
|
||
Ready to contribute? Here\'s how to set up | ||
`cookiecutter-poetry` for local development. Please note | ||
this documentation assumes you already have `poetry` and | ||
`git` installed and ready to go. | ||
Ready to contribute? Here\'s how to set up `cookiecutter-poetry` for local development. | ||
Please note this documentation assumes you already have `poetry` and `git` installed and ready to go. | ||
|
||
1. Fork the `cookiecutter-poetry` repo on GitHub. | ||
|
||
2. Clone your fork locally: | ||
|
||
``` bash | ||
cd <directory_in_which_repo_should_be_created | ||
git clone [email protected]:YOUR_NAME/cookiecutter-poetry.git | ||
``` | ||
```bash | ||
cd <directory_in_which_repo_should_be_created | ||
git clone [email protected]:YOUR_NAME/cookiecutter-poetry.git | ||
``` | ||
|
||
3. Now we need to install the environment. Navigate into the project directory: | ||
3. Now we need to install the environment. | ||
Navigate into the project directory: | ||
|
||
``` bash | ||
```bash | ||
cd cookiecutter-poetry | ||
``` | ||
|
||
If you are using `pyenv`, select a version to use locally. (See | ||
installed versions with `pyenv versions`) | ||
If you are using `pyenv`, select a version to use locally. | ||
(See installed versions with `pyenv versions`) | ||
|
||
``` bash | ||
```bash | ||
pyenv local <x.y.z | ||
``` | ||
|
||
Then, install and activate the environment with: | ||
|
||
``` bash | ||
```bash | ||
poetry install | ||
poetry shell | ||
``` | ||
|
||
|
||
4. Install pre-commit to run linters/formatters at commit time: | ||
|
||
poetry run pre-commit install | ||
poetry run pre-commit install | ||
|
||
5. Create a branch for local development: | ||
|
||
``` bash | ||
```bash | ||
git checkout -b name-of-your-bugfix-or-feature | ||
``` | ||
|
||
Now you can make your changes locally. | ||
|
||
6. Don\'t forget to add test cases for your added functionality to the | ||
`tests` directory. | ||
6. Don\'t forget to add test cases for your added functionality to the `tests` directory. | ||
|
||
7. When you\'re done making changes, check that your changes pass the | ||
formatting tests. | ||
7. When you\'re done making changes, check that your changes pass the formatting tests. | ||
|
||
``` bash | ||
```bash | ||
make check | ||
``` | ||
|
||
8. Now, validate that all unit tests are passing: | ||
|
||
``` bash | ||
```bash | ||
make test | ||
``` | ||
|
||
9. Before raising a pull request you should also run tox. This will | ||
run the tests across different versions of Python: | ||
9. Before raising a pull request you should also run tox. This will run the tests across different versions of Python: | ||
|
||
``` bash | ||
```bash | ||
tox | ||
``` | ||
|
||
This requires you to have multiple versions of Python installed. This | ||
step is also triggered in the CI/CD pipeline, so you could also choose | ||
to skip this step locally. | ||
This requires you to have multiple versions of Python installed. | ||
This step is also triggered in the CI/CD pipeline, so you could also choose to skip this step locally. | ||
|
||
10. Reflect your changes in the documentation. Update relevant files in | ||
the `docs` directory, and potentially the `README`. You can check the | ||
updated documentation with | ||
10. Reflect your changes in the documentation. Update relevant files in the `docs` directory, and potentially the `README`. | ||
You can check the updated documentation with: | ||
|
||
``` bash | ||
```bash | ||
make docs | ||
``` | ||
|
||
11. Commit your changes and push your branch to GitHub: | ||
|
||
``` bash | ||
```bash | ||
git add . | ||
git commit -m "Your detailed description of your changes." | ||
git push origin name-of-your-bugfix-or-feature | ||
|
@@ -148,5 +134,4 @@ Before you submit a pull request, check that it meets these guidelines: | |
|
||
1. The pull request should include tests. | ||
2. If the pull request adds functionality, the docs should be updated. | ||
Put your new functionality into a function with a docstring, and add | ||
the feature to the list in README.rst. | ||
Put your new functionality into a function with a docstring, and add the feature to the list in README.rst. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.