Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for argent account #2045

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Add tests for argent account #2045

merged 3 commits into from
Apr 19, 2024

Conversation

ddoktorski
Copy link
Contributor

Towards #1855

Introduced changes

  • Add fixture to deploy an argent account
  • Run tests using the deployed argent account

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@ddoktorski ddoktorski requested a review from a team as a code owner April 18, 2024 12:38
@ddoktorski ddoktorski requested review from THenry14 and DelevoXDG and removed request for a team April 18, 2024 12:38
@ddoktorski ddoktorski added this pull request to the merge queue Apr 19, 2024
Merged via the queue into master with commit a1d9f12 Apr 19, 2024
13 checks passed
@ddoktorski ddoktorski deleted the ddoktorski/test-argent-accounts branch April 19, 2024 10:07
@ddoktorski ddoktorski mentioned this pull request Apr 19, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this pull request May 8, 2024
@ddoktorski
Add type field to accounts file (#2050)
c1becf5 
<!-- Reference any GitHub issues resolved by this PR -->

Towards #1855

Discussed at
#2045 (comment)

## Introduced changes

<!-- A brief description of the changes -->

- Add required flag `--type` to `account add` command
- Save account type information in the accounts file

## Checklist

<!-- Make sure all of these are complete -->

- [X] Linked relevant issue
- [X] Updated relevant documentation
- [X] Added relevant tests
- [X] Performed self-review of the code
- [X] Added changes to `CHANGELOG.md`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@THenry14 THenry14 THenry14 approved these changes

@DelevoXDG DelevoXDG Awaiting requested review from DelevoXDG DelevoXDG was automatically assigned from foundry-rs/starknet-foundry-cast

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddoktorski @THenry14