Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type field to accounts file #2050

Merged
merged 11 commits into from
May 8, 2024
Merged

Add type field to accounts file #2050

merged 11 commits into from
May 8, 2024

Conversation

ddoktorski
Copy link
Contributor

@ddoktorski ddoktorski commented Apr 19, 2024 •
edited
Loading

Towards #1855

Discussed at #2045 (comment)

Introduced changes

  • Add required flag --type to account add command
  • Save account type information in the accounts file

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@ddoktorski ddoktorski requested a review from a team as a code owner April 19, 2024 14:41
@ddoktorski ddoktorski requested review from THenry14 and MaksymilianDemitraszek and removed request for a team April 19, 2024 14:41
THenry14
THenry14 approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@THenry14 THenry14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

MaksymilianDemitraszek
MaksymilianDemitraszek requested changes Apr 22, 2024
View reviewed changes
crates/sncast/src/starknet_commands/account/add.rs Show resolved Hide resolved
crates/sncast/src/starknet_commands/account/mod.rs Show resolved Hide resolved
crates/sncast/tests/e2e/account/add.rs Outdated Show resolved Hide resolved
docs/src/starknet/account.md Show resolved Hide resolved
docs/src/starknet/index.md Outdated Show resolved Hide resolved
MaksymilianDemitraszek
MaksymilianDemitraszek approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@MaksymilianDemitraszek MaksymilianDemitraszek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything except the type name looks good

@ddoktorski ddoktorski added this pull request to the merge queue May 8, 2024
@ddoktorski ddoktorski removed this pull request from the merge queue due to a manual request May 8, 2024
@ddoktorski ddoktorski added this pull request to the merge queue May 8, 2024
Merged via the queue into master with commit c1becf5 May 8, 2024
13 checks passed
@ddoktorski ddoktorski deleted the ddoktorski/account-type-field branch May 8, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@THenry14 THenry14 THenry14 approved these changes

@MaksymilianDemitraszek MaksymilianDemitraszek MaksymilianDemitraszek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ddoktorski @THenry14 @MaksymilianDemitraszek