Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor RunnerParams and RunnerConfig, add test_artifacts_path to ContextData #2032

Merged
merged 6 commits into from
Apr 22, 2024
Merged

Refactor RunnerParams and RunnerConfig, add test_artifacts_path to ContextData #2032

merged 6 commits into from
Apr 22, 2024

Conversation

piotmag769
Copy link
Member

Follow up for #2030, enabling me to pass path to test artifacts to forge-runner in a civilised way (will add business logic needed by profiler in the next PR)

Introduced changes

  • removed RunnerParams and RunnerConfig, introduce new structs ForgeConfig and ContextData and new substructs, making it more ordered. Moved relevant code to separate modules
  • added test_artifacts_path to ContextData (this info was not present before, see description above)

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@piotmag769 piotmag769 requested review from a team as code owners April 16, 2024 18:36
@piotmag769 piotmag769 requested review from Arcticae, Draggu, MaksymilianDemitraszek and ddoktorski and removed request for a team April 16, 2024 18:36
@piotmag769 piotmag769 changed the base branch from master to refactor-runner-args April 16, 2024 18:37
Arcticae
Arcticae reviewed Apr 17, 2024
View reviewed changes
crates/forge-runner/src/forge_config.rs Outdated Show resolved Hide resolved
crates/forge-runner/src/forge_config.rs Outdated Show resolved Hide resolved
crates/forge-runner/src/forge_config.rs Outdated Show resolved Hide resolved
@piotmag769 piotmag769 requested a review from drknzz April 17, 2024 12:43
MaksymilianDemitraszek
MaksymilianDemitraszek requested changes Apr 17, 2024
View reviewed changes
Copy link
Member

@MaksymilianDemitraszek MaksymilianDemitraszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the semantics here, some motivation should be provided.

crates/forge-runner/src/context_data.rs Outdated Show resolved Hide resolved
crates/forge-runner/src/forge_config.rs Outdated Show resolved Hide resolved
crates/forge-runner/src/forge_config.rs Outdated Show resolved Hide resolved
@piotmag769 piotmag769 mentioned this pull request Apr 17, 2024
Merged
5 tasks
@Arcticae
Copy link
Contributor

Also - i feel like we use Params/Data/ Context arbitrarily and we should agree on some convention here

Base automatically changed from refactor-runner-args to master April 22, 2024 16:21
@piotmag769 piotmag769 added this pull request to the merge queue Apr 22, 2024
Merged via the queue into master with commit 1687ad3 Apr 22, 2024
13 checks passed
@piotmag769 piotmag769 deleted the more-refactoring branch April 22, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaksymilianDemitraszek MaksymilianDemitraszek MaksymilianDemitraszek approved these changes

@Arcticae Arcticae Arcticae approved these changes

@Draggu Draggu Draggu approved these changes

@ddoktorski ddoktorski Awaiting requested review from ddoktorski ddoktorski was automatically assigned from foundry-rs/starknet-foundry-cast

@drknzz drknzz Awaiting requested review from drknzz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@piotmag769 @Arcticae @MaksymilianDemitraszek @Draggu