Add sierra path to contracts data #2030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotmag769
requested review from
Arcticae,
Draggu,
MaksymilianDemitraszek,
DelevoXDG,
a team and
THenry14
and removed request for
a team and
DelevoXDG
piotmag769
changed the title
crates/cheatnet/src/runtime_extensions/forge_runtime_extension/contracts_data.rs
Outdated
Show resolved
Hide resolved
5 tasks
Arcticae
reviewed
Apr 17, 2024
piotmag769
force-pushed
the
refactor-runner-args
branch
from
e09ab42
to
fe0d5a3
Compare
Draggu
approved these changes
Apr 17, 2024
MaksymilianDemitraszek
requested changes
Apr 17, 2024
crates/cheatnet/src/runtime_extensions/forge_runtime_extension/contracts_data.rs
Show resolved
Hide resolved
crates/cheatnet/src/runtime_extensions/forge_runtime_extension/contracts_data.rs
Show resolved
Hide resolved
crates/cheatnet/src/runtime_extensions/forge_runtime_extension/contracts_data.rs
Show resolved
Hide resolved
crates/cheatnet/src/runtime_extensions/forge_runtime_extension/contracts_data.rs
Show resolved
Hide resolved
crates/cheatnet/src/runtime_extensions/forge_runtime_extension/contracts_data.rs
Show resolved
Hide resolved
crates/cheatnet/src/runtime_extensions/forge_runtime_extension/contracts_data.rs
Show resolved
Hide resolved
crates/cheatnet/src/runtime_extensions/forge_runtime_extension/contracts_data.rs
Show resolved
Hide resolved
crates/cheatnet/src/runtime_extensions/forge_runtime_extension/contracts_data.rs
Show resolved
Hide resolved
crates/cheatnet/src/runtime_extensions/forge_runtime_extension/contracts_data.rs
Show resolved
Hide resolved
|
@MaksymilianDemitraszek pushed by accident to #2032, look there pls (already rebased the third PR on top of these two :/). Mostly renames, so it shouldn't be a problem |
Arcticae
approved these changes
Apr 18, 2024
MaksymilianDemitraszek
approved these changes
Apr 22, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 22, 2024
… to `ContextData` (#2032) Follow up for #2030, enabling me to pass path to test artifacts to `forge-runner` in a civilised way (will add business logic needed by profiler in the next PR) ## Introduced changes - removed `RunnerParams` and `RunnerConfig`, introduce new structs `ForgeConfig` and `ContextData` and new substructs, making it more ordered. Moved relevant code to separate modules - added `test_artifacts_path` to `ContextData` (this info was not present before, see description above) ## Checklist - [x] Linked relevant issue - [x] Updated relevant documentation - [x] Added relevant tests - [x] Performed self-review of the code - [x] Added changes to `CHANGELOG.md`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for adding paths to sierra code to trace (needed by profiler - more PRs incoming)
Introduced changes
ContractsDataload_test_artifactsout ofrunfunction (I need the path to test artifacts in the next next PR)Checklist
CHANGELOG.md