Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support argent accounts #1855

Closed
THenry14 opened this issue Mar 11, 2024 · 0 comments
Closed

Support argent accounts #1855

THenry14 opened this issue Mar 11, 2024 · 0 comments
Assignees
@ksew1
Labels
design-doc sncast

Comments

@THenry14
Copy link
Contributor

THenry14 commented Mar 11, 2024 •
edited
Loading

Which component is your feature related to?

Cast

Feature Request

We should have on par to OZ support for argent accounts in sncast.
Let's start with argent account usage, it should be possible to:

  • import already existing argent account to accounts file (account add)
  • remove argent account from accounts file (account delete - this should already be possible, but let's double check)
  • use an argent account to make transactions

It may be handy to annotate non-oz accounts with a type in the accounts file. While adding such accounts let's remember to include this info in it.

The documentation should also be updated to include information on what is currently supported, what is the support's scope, and what is still planned for the future.

After this is done, we should think about creating and deploying such accounts using sncast. This should be rather easy, since it seems to be support for this in the sdk.
@github-actions github-actions bot added the new label Mar 11, 2024
@THenry14 THenry14 removed the new label Mar 11, 2024
@THenry14 THenry14 mentioned this issue Mar 18, 2024
Closed
@ddoktorski ddoktorski mentioned this issue Apr 18, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Apr 19, 2024
@ddoktorski
Add tests for argent account (#2045)
a1d9f12 
<!-- Reference any GitHub issues resolved by this PR -->

Towards #1855 

## Introduced changes

<!-- A brief description of the changes -->

- Add fixture to deploy an argent account
- Run tests using the deployed argent account

## Checklist

<!-- Make sure all of these are complete -->

- [X] Linked relevant issue
- [ ] Updated relevant documentation
- [X] Added relevant tests
- [X] Performed self-review of the code
- [ ] Added changes to `CHANGELOG.md`
@ddoktorski ddoktorski mentioned this issue Apr 19, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue May 8, 2024
@ddoktorski
Add type field to accounts file (#2050)
c1becf5 
<!-- Reference any GitHub issues resolved by this PR -->

Towards #1855

Discussed at
#2045 (comment)

## Introduced changes

<!-- A brief description of the changes -->

- Add required flag `--type` to `account add` command
- Save account type information in the accounts file

## Checklist

<!-- Make sure all of these are complete -->

- [X] Linked relevant issue
- [X] Updated relevant documentation
- [X] Added relevant tests
- [X] Performed self-review of the code
- [X] Added changes to `CHANGELOG.md`
This was referenced May 9, 2024
Merged
Merged
Merged
github-merge-queue bot pushed a commit that referenced this issue May 28, 2024
@ddoktorski
Enable creating argent accounts (#2100)
6396e61 
<!-- Reference any GitHub issues resolved by this PR -->

Towards #1855 

## Introduced changes

<!-- A brief description of the changes -->

- Enable creating an argent account to the accounts file and starkli
format

## Checklist

<!-- Make sure all of these are complete -->

- [X] Linked relevant issue
- [X] Updated relevant documentation
- [X] Added relevant tests
- [X] Performed self-review of the code
- [X] Added changes to `CHANGELOG.md`
Draggu pushed a commit that referenced this issue May 28, 2024
@ddoktorski
Enable deploying argent accounts (#2107)
f8c8393 
<!-- Reference any GitHub issues resolved by this PR -->


Towards #1855 

## Introduced changes

**[WIP]**

<!-- A brief description of the changes -->

- Support deploying argent account from the accounts file and starkli
account

## Checklist

<!-- Make sure all of these are complete -->

- [ ] Linked relevant issue
- [ ] Updated relevant documentation
- [ ] Added relevant tests
- [ ] Performed self-review of the code
- [ ] Added changes to `CHANGELOG.md`
@Arcticae Arcticae assigned ksew1 and unassigned ddoktorski Jun 3, 2024
github-merge-queue bot pushed a commit that referenced this issue Jun 3, 2024
@ddoktorski @Draggu
Refactor account deploy (#2101)
8db77b7 
<!-- Reference any GitHub issues resolved by this PR -->

Towards #1854 #1855  

## Introduced changes

<!-- A brief description of the changes -->

- Include account type information in `AccountData`
- Refactor `account deploy` code to simplify adding support for argent
and braavos accounts
- Remove `--class-hash` flag
- Use `get_account_data_from_accounts_file` and
`get_account_data_from_keystore` functions to retrieve account
information

## Checklist

<!-- Make sure all of these are complete -->

- [X] Linked relevant issue
- [X] Updated relevant documentation
- [X] Added relevant tests
- [X] Performed self-review of the code
- [X] Added changes to `CHANGELOG.md`

---------

Co-authored-by: Piotr Figiela <[email protected]>
@Arcticae Arcticae closed this as completed Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ksew1 ksew1

Labels
design-doc sncast
Projects
Starknet foundry
Archived in project
Milestone
No milestone
Development

No branches or pull requests
5 participants
@THenry14 @MaksymilianDemitraszek @Arcticae @ddoktorski @ksew1