Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use relative path for git commands in install cmd #623

Merged
merged 2 commits into from
Jan 30, 2022
Merged

Use relative path for git commands in install cmd #623

merged 2 commits into from
Jan 30, 2022

Conversation

onbjerg
Copy link
Member

@onbjerg onbjerg commented Jan 29, 2022 •
edited
Loading

Motivation

Paths to git commands when running forge install and forge init are broken on Windows.

Solution

Make the paths relative to the root of the project where relevant, which fixes the issue - keeping this as a draft until I have tested it on Windows

Remaining tasks

  • Test on Windows
  • Check exit code of git commands so they don't fail silently

Fixes #621 and fixes #631

@onbjerg onbjerg added the T-bug Type: bug label Jan 29, 2022
@brockelmore
Copy link
Member

brockelmore commented Jan 29, 2022 •
edited
Loading

Closes #613

@onbjerg
Copy link
Member Author

onbjerg commented Jan 29, 2022

Yeah, it would

@brockelmore brockelmore linked an issue Jan 29, 2022 that may be closed by this pull request
forge install uses absolute path in git submodule configuration #613
Closed
2 tasks
gakonst
gakonst approved these changes Jan 30, 2022
View reviewed changes
Copy link
Member

@gakonst gakonst left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cautiously merging this so we trigger the windows tests on master, and we can revert if it doesn't fix. It looks right to me. Linter error is unrelated and is fixed on master

@gakonst gakonst marked this pull request as ready for review January 30, 2022 11:11
@gakonst gakonst merged commit a5e8c44 into foundry-rs:master Jan 30, 2022
@onbjerg onbjerg deleted the onbjerg/fix-forge-win-path branch January 30, 2022 11:28
@calldata
Copy link
Contributor

uh, why this pr fix #631 ?

@onbjerg
Copy link
Member Author

onbjerg commented Jan 30, 2022

I linked to the wrong PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
T-bug Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

forge install does not work on Windows forge install uses absolute path in git submodule configuration
4 participants
@onbjerg @brockelmore @calldata @gakonst