Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forge install uses absolute path in git submodule configuration #613

Closed
2 tasks done
JakkuSakura opened this issue Jan 28, 2022 · 0 comments · Fixed by #623
Closed
2 tasks done

forge install uses absolute path in git submodule configuration #613

JakkuSakura opened this issue Jan 28, 2022 · 0 comments · Fixed by #623
Labels
C-forge Command: forge Cmd-forge-pm Command: forge install/update/remove D-average Difficulty: average P-high Priority: high T-bug Type: bug

Comments

@JakkuSakura
Copy link

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

forge 0.1.0 (9de25d1 2022-01-26T00:23:17.475991931+00:00)

What command(s) is the bug in?

forge install OpenZeppelin/openzeppelin-contracts

Operating System

Linux

Describe the bug

Forge install uses absolute path in git submodule configuration.
This is will fail github action because git couldn't find submodule by lib/openzeppelin-contracts

[submodule "/home/jack/Dev/InfinityToken/lib/openzeppelin-contracts"]
	path = /home/jack/Dev/InfinityToken/lib/openzeppelin-contracts
	url = https://github.com/OpenZeppelin/openzeppelin-contracts

I have to change it to

[submodule "lib/openzeppelin-contracts"]
	path = lib/openzeppelin-contracts
	url = https://github.com/OpenZeppelin/openzeppelin-contracts
@JakkuSakura JakkuSakura added the T-bug Type: bug label Jan 28, 2022
@onbjerg onbjerg added C-forge Command: forge D-average Difficulty: average P-high Priority: high Cmd-forge-pm Command: forge install/update/remove labels Jan 28, 2022
@brockelmore brockelmore linked a pull request Jan 29, 2022 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-forge Command: forge Cmd-forge-pm Command: forge install/update/remove D-average Difficulty: average P-high Priority: high T-bug Type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants