-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update translations for "Call for Speakers" #58
base: development
Are you sure you want to change the base?
Conversation
Fixes translation issues caused due to PR: fossasia#33
89adb67
to
acd9a0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few questions of removals I don't understand, can you please re-check the changes?
#: pretalx/orga/templates/orga/base.html:404 | ||
msgid "Organisers" | ||
msgstr "Organisateurs" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this being removed? Isn't this still relevant for this:
<span>{% translate "Organisers" %}</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#: pretalx/mail/context.py:247 | ||
msgid "Jane Doe" | ||
msgstr "Jane Doe" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this being removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same answer as the the other one
#: pretalx/mail/context.py:247 | ||
msgid "Jane Doe" | ||
msgstr "Fulanita de Tal" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this relevant for
eventyay-talk/src/pretalx/mail/context.py
Line 247 in 297c53e
_("Jane Doe"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same answer applies here.
@marcoag Yup. I reviewed and they are just moved to different places. The process is automated by Django makemessages. |
Fixes translation issues caused due to PR: #33
Related to issue - #46
The PR changes some other translations as well, which were automated by the Django makemessages module.
This can be caused due to the translations not being updated in past.