Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-7733: remove stale types #5513

Merged
merged 2 commits into from
Apr 23, 2024
Merged

FIO-7733: remove stale types #5513

merged 2 commits into from
Apr 23, 2024

Conversation

brendanbond
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-7733

Description

Previously, the package.json file in this repo was pointing to manually crafted types in the ./types folder. These types are 4 years old and stale. Now that we use Typescript to build the library, we should be using the colocated *.d.ts files in lib, which come for free without the "types" parameter in the package.json

Breaking Changes / Backwards Compatibility

Shouldn't be an issue; in fact, should improve dev ex by using up-to-date type definitions from the build step.

Dependencies

n/a

How has this PR been tested?

n/a

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@travist travist merged commit 6012b5c into master Apr 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants