-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIO-7733: type the form component #558
Conversation
@brendanbond Do we need PR to type the FormBuilder ? I do have experience with it. |
@gyanendrasinghpanwar I started that today, perhaps since i'm going from top to bottom you could go bottom to top and meet in the middle, maybe you could start typing FormGrid? |
@brendanbond Absolutely, sounds like a solid plan! I'm ready to collaborate on getting the builder ready. Going from bottom to top works for me. Once we've got that sorted, we can dive into FormGrid or FormEdit. Feel free to share any suggestions or preferences along the way. |
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-7733
Description
General Updates
Updates to
<Form />
src
prop to resemble thecreateForm
API (i.e. it takes either a form definition or a form url)useRef
Breaking Changes / Backwards Compatibility
Generally speaking the goal is to be backwards compatible here (see e.g. the
getEffectiveProps
function), but I would point the reviewer specifically towards the EventEmitter change and broadly towards testing this PR in your own existing application so we can be sure that everything works properly.Dependencies
How has this PR been tested?
I've loaded this PR into a simple Next.js application to ensure everything works as expected. Also, now that we've moved away from karma, I expect to add more tests in the next major PR to this library.
Checklist: