Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove misleading address field from Ray Task #2870

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove misleading address field from Ray Task #2870

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions plugins/flytekit-ray/flytekitplugins/ray/task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ class RayJobConfig:
head_node_config: typing.Optional[HeadNodeConfig] = None
enable_autoscaling: bool = False
runtime_env: typing.Optional[dict] = None
address: typing.Optional[str] = None
shutdown_after_job_finishes: bool = False
ttl_seconds_after_finished: typing.Optional[int] = None

Expand All @@ -65,7 +64,7 @@ def __init__(self, task_config: RayJobConfig, task_function: Callable, **kwargs)
self._task_config = task_config

def pre_execute(self, user_params: ExecutionParameters) -> ExecutionParameters:
init_params = {"address": self._task_config.address}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. I think this only works for local execution. For those people who still want to use it, they can use RAY_ADDRESS env.

init_params = {}

ctx = FlyteContextManager.current_context()
if not ctx.execution_state.is_local_execution():
Expand Down
Loading