Remove misleading address field from Ray Task #2870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Parraga <[email protected]>
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Sovietaced
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy,
samhita-alla,
thomasjpfan and
Future-Outlier
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2870 +/- ##
===========================================
+ Coverage 45.53% 92.37% +46.83%
===========================================
Files 196 126 -70
Lines 20418 5417 -15001
Branches 2647 0 -2647
===========================================
- Hits 9298 5004 -4294
+ Misses 10658 413 -10245
+ Partials 462 0 -462 ☔ View full report in Codecov by Sentry. |
Correct. If we want to keep backwards compatibility I can close this. I was't sure how stable these plugins are meant to be, especially this one. |
pingsutw
reviewed
Oct 28, 2024
| @@ -65,7 +64,7 @@ def __init__(self, task_config: RayJobConfig, task_function: Callable, **kwargs) | |||
| self._task_config = task_config | |||
|
|
|||
| def pre_execute(self, user_params: ExecutionParameters) -> ExecutionParameters: | |||
| init_params = {"address": self._task_config.address} | |||
There was a problem hiding this comment.
thanks. I think this only works for local execution. For those people who still want to use it, they can use RAY_ADDRESS env.
pingsutw
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes flyteorg/flyte#5877
Why are the changes needed?
The documentation implies that you can run a ray job on an existing cluster by configuring the address but this is not true since the task still requires users to configure details for a new and dynamically created Ray Cluster. And ray jobs will run on the dynamically created Ray Cluster even if an address is configured.
Check all the applicable boxes
Related PRs
flyteorg/flytesnacks#1765