-
-
Notifications
You must be signed in to change notification settings - Fork 980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(battery_plus): Add Swift Package Manager support #3154
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3e3ea9e
feat(battery_plus): Support Swift Package Manager
koji-1009 99df256
fix: Add new line
koji-1009 fa35541
chore: Fix privacy manifest resource bundle name
koji-1009 9cba529
Merge branch 'main' into feat/spm_battery
koji-1009 92397e2
feat: Update privacy manifest settings on macos
koji-1009 7247549
refatcor: Format by swift-format
koji-1009 581d198
Merge branch 'main' into feat/spm_battery
vbuberen 09f4acc
fix(battery_plus): Update MacOS privacy manifest according to latest …
vbuberen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,11 +14,11 @@ Downloaded by pub (not CocoaPods). | |
s.author = { 'Flutter Community Team' => '[email protected]' } | ||
s.source = { :http => 'https://github.com/fluttercommunity/plus_plugins/tree/main/packages/battery_plus' } | ||
s.documentation_url = 'https://pub.dev/packages/battery_plus' | ||
s.source_files = 'Classes/**/*' | ||
s.public_header_files = 'Classes/**/*.h' | ||
s.source_files = 'battery_plus/Sources/battery_plus/**/*.{h,m}' | ||
s.public_header_files = 'battery_plus/Sources/battery_plus/include/**/*.h' | ||
s.dependency 'Flutter' | ||
|
||
s.platform = :ios, '12.0' | ||
s.pod_target_xcconfig = { 'DEFINES_MODULE' => 'YES' } | ||
s.resource_bundles = {'batery_plus_privacy' => ['PrivacyInfo.xcprivacy']} | ||
s.resource_bundles = {'batery_plus_privacy' => ['battery_plus/Sources/battery_plus/PrivacyInfo.xcprivacy']} | ||
end |
27 changes: 27 additions & 0 deletions
27
packages/battery_plus/battery_plus/ios/battery_plus/Package.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
// swift-tools-version: 5.9 | ||
// The swift-tools-version declares the minimum version of Swift required to build this package. | ||
|
||
import PackageDescription | ||
|
||
let package = Package( | ||
name: "battery_plus", | ||
platforms: [ | ||
.iOS("12.0") | ||
], | ||
products: [ | ||
.library(name: "battery-plus", targets: ["battery_plus"]) | ||
], | ||
dependencies: [], | ||
targets: [ | ||
.target( | ||
name: "battery_plus", | ||
dependencies: [], | ||
resources: [ | ||
.process("PrivacyInfo.xcprivacy"), | ||
], | ||
cSettings: [ | ||
.headerSearchPath("include/battery_plus") | ||
] | ||
) | ||
] | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,7 +13,7 @@ A Flutter plugin for accessing information about the battery state(full, chargin | |
s.license = { :file => '../LICENSE' } | ||
s.author = { 'Flutter Community' => '[email protected]' } | ||
s.source = { :path => 'https://github.com/fluttercommunity/plus_plugins/tree/main/packages/battery_plus' } | ||
s.source_files = 'Classes/**/*' | ||
s.source_files = 'battery_plus/Sources/battery_plus/**/*.swift' | ||
s.dependency 'FlutterMacOS' | ||
|
||
s.platform = :osx, '10.14' | ||
|
22 changes: 22 additions & 0 deletions
22
packages/battery_plus/battery_plus/macos/battery_plus/Package.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
// swift-tools-version: 5.9 | ||
// The swift-tools-version declares the minimum version of Swift required to build this package. | ||
|
||
import PackageDescription | ||
|
||
let package = Package( | ||
name: "battery_plus", | ||
platforms: [ | ||
.macOS("10.14") | ||
], | ||
products: [ | ||
.library(name: "battery-plus", targets: ["battery_plus"]) | ||
], | ||
dependencies: [], | ||
targets: [ | ||
.target( | ||
name: "battery_plus", | ||
dependencies: [], | ||
resources: [] | ||
) | ||
] | ||
) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: add new line here |
File renamed without changes.
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should
batery
bebattery
here?