feat(battery_plus): Add Swift Package Manager support #3154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koji-1009
force-pushed
the
feat/spm_battery
branch
3 times, most recently
from
59ed5b4
to
9ba32e4
Compare
koji-1009
force-pushed
the
feat/spm_battery
branch
from
9ba32e4
to
3e3ea9e
Compare
|
I would be happy to include flutter/website PR and feel free to review it. There is no need to rush and we would like to discuss how it should be implemented. |
charafau
reviewed
Aug 11, 2024
There was a problem hiding this comment.
hi @koji-1009 ! thanks for contribution. I ran pod lint on macos projects and get few warnings:
➜ battery_plus pod lib lint macos/battery_plus.podspec --configuration=Debug --skip-tests --use-modular-headers
-> battery_plus (0.0.1)
- WARN | license: Missing license type.
- WARN | [OSX] keys: Missing primary key for `source` attribute. The acceptable ones are: `git, hg, http, svn`.
- NOTE | xcodebuild: note: Using codesigning identity override:
- NOTE | [OSX] xcodebuild: note: Building targets in dependency order
- NOTE | [OSX] xcodebuild: note: Target dependency graph (4 targets)
- NOTE | [OSX] xcodebuild: note: Metadata extraction skipped. No AppIntents.framework dependency found. (in target 'battery_plus' from project 'Pods')
- NOTE | [OSX] xcodebuild: note: Metadata extraction skipped. No AppIntents.framework dependency found. (in target 'App' from project 'App')
[!] battery_plus did not pass validation, due to 2 warnings (but you can use `--allow-warnings` to ignore them).
You can use the `--no-clean` option to inspect any issue.
➜ battery_plus pod lib lint macos/battery_plus.podspec --configuration=Debug --skip-tests --use-modular-headers --use-libraries
-> battery_plus (0.0.1)
- WARN | license: Missing license type.
- WARN | [OSX] keys: Missing primary key for `source` attribute. The acceptable ones are: `git, hg, http, svn`.
- NOTE | xcodebuild: note: Using codesigning identity override:
- NOTE | [OSX] xcodebuild: note: Building targets in dependency order
- NOTE | [OSX] xcodebuild: note: Target dependency graph (4 targets)
- NOTE | [OSX] xcodebuild: note: Metadata extraction skipped. No AppIntents.framework dependency found. (in target 'App' from project 'App')
[!] battery_plus did not pass validation, due to 2 warnings (but you can use `--allow-warnings` to ignore them).
You can use the `--no-clean` option to inspect any issue.
not sure if they were there before but it would be nice to fix it
charafau
approved these changes
Aug 11, 2024
|
The contents of the |
miquelbeltran
added
battery_plus
loic-sharma
reviewed
Aug 15, 2024
| resources: [] | ||
| ) | ||
| ] | ||
| ) |
There was a problem hiding this comment.
Nit: add new line here
loic-sharma
reviewed
Aug 15, 2024
| s.dependency 'Flutter' | ||
|
|
||
| s.platform = :ios, '12.0' | ||
| s.pod_target_xcconfig = { 'DEFINES_MODULE' => 'YES' } | ||
| s.resource_bundles = {'batery_plus_privacy' => ['PrivacyInfo.xcprivacy']} | ||
| s.resource_bundles = {'batery_plus_privacy' => ['battery_plus/Sources/battery_plus/PrivacyInfo.xcprivacy']} |
There was a problem hiding this comment.
Should batery be battery here?
vbuberen
changed the title
vbuberen
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add SPM support.
https://docs.flutter.dev/packages-and-plugins/swift-package-manager/for-plugin-authors
I also noticed an error in the documentation.
Since we need to refer to the documentation when reviewing PRs, it will be draft until the next PR is reviewed.
flutter/website#11020
As a working test, I have confirmed that it can be built with flutter 3.24 + CocoaPods, and that it can be built with flutter main channel + SPM.
Note that if you try building with main channel + SPM, you will need to remove some steps from your iOS project, as the script to add Pods is no longer needed.
Related Issues
Checklist
CHANGELOG.mdnor the plugin version inpubspec.yamlfiles.flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).