-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new side-hinge box #675
Conversation
0addb4d
to
1e190d8
Compare
This is really neat. I polished a few minor blemishes. Shipping the OpenSCAD "file" as text in the drawing is super cool. I wonder if the button could also be made completely laser cut - using a long leave spring and two circles. I might try that as soon as this gets merged. |
I wonder if you can just on the fly modify the button code to fit the thickness. Simply by putting |
Well, Indeed it's already the case ^^ |
Yeah, I only really saw that after commenting. As I understand the 3.7mm is the travel of the key. What about using In general raising an Exception for such thing is fine. But the Exception to raise is |
Yes that's a good idea! Maybe with a warning in the description, if I'm not mistaken in such a case the switch would need to be inserted before adding the walls and wouldn't be removable. Under 3.7mm, you can remove the square to push further the button, and there is then enough room to remove and replace it. |
If you limit the switch height to 3.7mm as suggested above you can also always remove the switch after removing the square - at least as far as I understand the geometry from looking at the drawing alone. If you adjust the generated OpenSCAD code I think we are done here - unless someone suggests a better name. |
I just changed the latches option (in a dedicated commit), as an int to allow for a second one. I found afterward that a second latch on the opposite side would have been more adapted for the box size and content I did.
Yes, you are right. I changed the OpenSCAD code (there were other impacted lines too)
It looks good to ship for me too🚀 |
A box with two hinged shells that fold open
90bd844
to
d732ce5
Compare
OK, added choices to the cherrymx_latches parameter so it is now a drop down with And a squashed all the commits into one. To me this also looks ready to be merged now. |
Hello,
I needed a box for a project, but with some constraints not met by the existing ones, so I created yet another hinge box.
The inside wall corner rounding is useful, but subtle to actually see. It's easier to see with more extreme values such as
hinge_radius 30
.I don't know if it's merge ready yet, since:
Thank you!