HTTP Based finders #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
santanusinha
commented
Dec 16, 2019
•
santanusinha
commented
- Signal generators to trigger updates
- Seperation between Node data source and sink and connector
- NodeDataSource abstracted and implemented for ZK and HTTP
- NodeDataSink implemented for ZK
- Registry cleaned up as pure data registry
- Updater is pure signal based updater and uses data source to fetch data
- Service Hub introduced for easy access to any service in the registry
* Signal generators to trigger updates * NodeDataSource abstracted and implemented for ZK * Registry cleaned up as pure data registry * Updater is pure signal based updater and uses data source to fetch data
* Moved out zk functionality from provider
* All ZK functionality moved to ranger-zookeeper
* Added data source * Added data sync * Added HTTP client
nimit95
reviewed
Mar 2, 2020
ranger-core/src/main/java/com/flipkart/ranger/core/finder/ServiceRegistryUpdater.java
Outdated
Show resolved
Hide resolved
… ListBasedServiceRegistry along with the MapBased one 1) Added a criteria interface in the ShardSelector to keep it seperate from the T in ServiceNode and trickled the changes upstream to whereever ShardSelector is getting built. 2) Added test cases to the new criteria interface 3) Added Http serivceNodeProvider and serviceFinders, along with the HttpServiceFinderHub 4) Added tests for Http interfaces as well. 5) Added license to the missing files 6) Fixed sonar issues
…for when it has to be latter passed down as an arg to a function. b) .equalsIgnoreCase in selector tests has crept in during the previous sonar lints, corrected the same. c) Addressed sonar lint issues on license block
…rce formatting c) Reverted the version change to have the APIs begin with a version
…ctions and added http and zk clients respectively with required test cases. This will help end-clients not replicate the same boiler plate code again and again
…an be used across for various modules
…uld both contain namespace and that is missing
…gCriteria in the rangerClients - simple & hub
…ll mutable types in the codebase
…case exec time from 3 minutes to 40 seconds
Removed the unnecessary error in GenericResponse
…g it for future, while not completely nailing down how a serviceProvider's errors may be manifested is not a good option, imo. In the case of a finderHub though, since there could be any of the hubs that may error out (and the errors are getting logged at the point whey they error out), one responseCode won't cut it. I don't think it is future provisioning as well, if anything this will hinder our ability to add proper error blocks in the future, when the need arises
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.